Conversation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Member
Author
|
/backport to stable24 |
tcitworld
approved these changes
Apr 20, 2022
artonge
approved these changes
Apr 20, 2022
miaulalala
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the correct
<calendar_name>_shared_by_<user>uri, e.g.work_shared_by_tim, instead of justwork(returned bygetCalendarById()) which will throw as SabreDAV will try to look for the potentially non-existent or mistake it with the user's owncalendars/me/workpath rather than the correctcalendars/me/work_shared_by_timpathThe date is removed from the filename as well as the export zip itself is timestamped, and the underscore no longer has special meaning as a separator